Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Custom Attributes in the Python API #246

Merged
merged 17 commits into from
Aug 29, 2023
Merged

Add Custom Attributes in the Python API #246

merged 17 commits into from
Aug 29, 2023

Conversation

sezna
Copy link
Collaborator

@sezna sezna commented Aug 22, 2023 •
edited
Loading

This pr:

  • Adds add_string_attribute to the exported FFI interface from Rust
  • Removes entry_point from that same interface
  • Implements entry_point in Python, consuming the add_string_attribute function

Closes #143

@sezna sezna marked this pull request as ready for review August 23, 2023 20:03
@sezna sezna mentioned this pull request Aug 24, 2023
Closed
@sezna sezna enabled auto-merge August 24, 2023 19:50
@sezna sezna merged commit e7d4892 into main Aug 29, 2023
12 checks passed
@sezna sezna deleted the alex/143 branch August 29, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idavis idavis idavis approved these changes

@bamarsha bamarsha Awaiting requested review from bamarsha

@minestarks minestarks Awaiting requested review from minestarks minestarks is a code owner

@swernli swernli Awaiting requested review from swernli swernli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom attributes to functions
2 participants
@sezna @idavis