Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more image extensions to PointImage test regex #220

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

functorism
Copy link
Contributor

@functorism functorism commented Aug 24, 2024

Just adds a few more common image extensions to the test regex in PointImage.

    function isImgUrl(string) {
      let url;
      try {
        url = new URL(string);
      } catch (_) {
        return false;
      }
      if (url) {
        return /\.(jpg|jpeg|png|webp|bmp|gif|ico|svg)$/.test(url.pathname);
      }
      return false;
    }

@functorism
Copy link
Contributor Author

Merge?

@timvisee
Copy link
Member

timvisee commented Sep 16, 2024

I'll do so. Thanks for your work on this, and the bump!

@timvisee timvisee merged commit 230842b into qdrant:master Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants