Quality check timeout (#228)

* rename SearchQualityPannel -> SearchQualityPanel, added timeout as param * fixes
qdrant · Aug 28, 2024 · 54f9e8c · 54f9e8c
1 parent a077ffa
commit 54f9e8c
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 15 deletions.
diff --git a/src/components/Collections/SearchQuality/SearchQuality.jsx b/src/components/Collections/SearchQuality/SearchQuality.jsx
@@ -2,7 +2,7 @@ import React, { useEffect } from 'react';
 import PropTypes from 'prop-types';
 import { getSnackbarOptions } from '../../Common/utils/snackbarOptions';
 import { useClient } from '../../../context/client-context';
-import SearchQualityPannel from './SearchQualityPannel';
+import SearchQualityPanel from './SearchQualityPanel';
 import { useSnackbar } from 'notistack';
 import { Box, Card, CardHeader } from '@mui/material';
 import { CopyButton } from '../../Common/CopyButton';
@@ -51,7 +51,7 @@ const SearchQuality = ({ collectionName }) => {
   return (
     <>
       {collection?.config?.params?.vectors && (
-        <SearchQualityPannel
+        <SearchQualityPanel
           collectionName={collectionName}
           vectors={vectors}
           loggingFoo={handleLogUpdate}

diff --git a/...ons/SearchQuality/SearchQualityPannel.jsx → ...ions/SearchQuality/SearchQualityPanel.jsx b/...ons/SearchQuality/SearchQualityPannel.jsx → ...ions/SearchQuality/SearchQualityPanel.jsx
@@ -73,7 +73,7 @@ VectorTableRow.propTypes = {
   isInProgress: PropTypes.bool,
 };
 
-const SearchQualityPannel = ({ collectionName, vectors, loggingFoo, clearLogsFoo, ...other }) => {
+const SearchQualityPanel = ({ collectionName, vectors, loggingFoo, clearLogsFoo, ...other }) => {
   const { client } = useClient();
   const vectorsNames = Object.keys(vectors);
   const [precision, setPrecision] = useState(() => {
@@ -110,7 +110,8 @@ const SearchQualityPannel = ({ collectionName, vectors, loggingFoo, clearLogsFoo
 //         "value": "field_value"
 //       }
 //     }
-//   }
+//   },
+//  "timeout": 20
 // }
 
   `);
@@ -153,14 +154,21 @@ const SearchQualityPannel = ({ collectionName, vectors, loggingFoo, clearLogsFoo
           },
         ],
       },
+      timeout: {
+        description: 'Timeout for search',
+        type: 'integer',
+        format: 'uint',
+        minimum: 1,
+        nullable: true,
+      },
     },
   });
 
   if (!vectors) {
     return <>No vectors</>;
   }
 
-  const onCheckIndexQuality = async ({ using = '', limit = 10, params = null, filter = null }) => {
+  const onCheckIndexQuality = async ({ using = '', limit = 10, params = null, filter = null, timeout }) => {
     setInProgress(true);
 
     clearLogsFoo && clearLogsFoo();
@@ -191,7 +199,8 @@ const SearchQualityPannel = ({ collectionName, vectors, loggingFoo, clearLogsFoo
           filter,
           params,
           using,
-          limit
+          limit,
+          timeout
         );
         if (precision) {
           precisions.push(precision);
@@ -311,12 +320,12 @@ const SearchQualityPannel = ({ collectionName, vectors, loggingFoo, clearLogsFoo
   );
 };
 
-SearchQualityPannel.propTypes = {
+SearchQualityPanel.propTypes = {
   collectionName: PropTypes.string,
   vectors: PropTypes.object.isRequired,
   loggingFoo: PropTypes.func,
   clearLogsFoo: PropTypes.func,
   other: PropTypes.object,
 };
 
-export default SearchQualityPannel;
+export default SearchQualityPanel;
diff --git a/src/components/Collections/SearchQuality/check-index-precision.js b/src/components/Collections/SearchQuality/check-index-precision.js
@@ -8,10 +8,9 @@ export const checkIndexPrecision = async (
   filter = null,
   params = null,
   vectorName = null,
-  limit = 10
+  limit = 10,
+  timeout = 20
 ) => {
-  const TIMEOUT = 20;
-
   try {
     const exactSearchtartTime = new Date().getTime();
 
@@ -25,15 +24,15 @@ export const checkIndexPrecision = async (
       },
       filter: filter,
       using: vectorName,
-      timeout: TIMEOUT,
+      timeout,
     });
 
     const exactSearchElapsed = new Date().getTime() - exactSearchtartTime;
 
     const searchStartTime = new Date().getTime();
 
     const hnsw = await client.query(collectionName, {
-      timeout: TIMEOUT,
+      timeout,
       limit: limit,
       with_payload: false,
       with_vectors: false,

diff --git a/src/components/EditorCommon/index.jsx b/src/components/EditorCommon/index.jsx
@@ -73,7 +73,7 @@ const EditorCommon = ({ beforeMount, customHeight, ...props }) => {
 EditorCommon.propTypes = {
   height: PropTypes.string,
   beforeMount: PropTypes.func,
-  customHeight: PropTypes.number,
+  customHeight: PropTypes.oneOfType([PropTypes.number, PropTypes.string]),
   ...Editor.propTypes,
 };
 

diff --git a/src/components/FilterEditorWindow/index.jsx b/src/components/FilterEditorWindow/index.jsx
@@ -118,6 +118,6 @@ CodeEditorWindow.propTypes = {
   code: PropTypes.string.isRequired,
   onChangeResult: PropTypes.func.isRequired,
   customRequestSchema: PropTypes.func.isRequired,
-  customHeight: PropTypes.number,
+  customHeight: PropTypes.oneOfType([PropTypes.number, PropTypes.string]),
 };
 export default CodeEditorWindow;