Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Pulumi integration #1177

Merged
merged 4 commits into from
Sep 23, 2024
Merged

docs: Pulumi integration #1177

merged 4 commits into from
Sep 23, 2024

Conversation

Anush008
Copy link
Member

@Anush008 Anush008 commented Sep 16, 2024 •
edited
Loading

@netlify Netlify
Copy link

netlify bot commented Sep 16, 2024 •
edited
Loading

✅ Deploy Preview for condescending-goldwasser-91acf0 ready!

Name Link
🔨 Latest commit 7640275
🔍 Latest deploy log https://app.netlify.com/sites/condescending-goldwasser-91acf0/deploys/66f128139540640008a9f02a
😎 Deploy Preview https://deploy-preview-1177--condescending-goldwasser-91acf0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mikheillomidzeq
mikheillomidzeq approved these changes Sep 23, 2024
View reviewed changes
Copy link

@mikheillomidzeq mikheillomidzeq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Thank you.

I have an optional suggeesstion, it may be helpful, if we add small explanation about packages in Usage section.

During cluster creation, there is used package_id, which does not make any sense for user.

mikheillomidzeq

This comment was marked as off-topic.

Sign in to view

@Anush008
Copy link
Member Author

During cluster creation, there is used package_id, which does not make any sense for user.

Got it. Will do.

@Anush008
Copy link
Member Author

@mikheillomidzeq, I've moved the mention of bookings/package IDs to the top.

See https://deploy-preview-1177--condescending-goldwasser-91acf0.netlify.app/documentation/platforms/pulumi/#usage

@Anush008 Anush008 merged commit 1383a84 into master Sep 23, 2024
5 checks passed
celinehoang177 pushed a commit to celinehoang177/landing_page that referenced this pull request Sep 30, 2024
@Anush008 @celinehoang177
docs: Pulumi integration (qdrant#1177)
2879978 
* docs: Pulumi

* chore: fixed typo

* docs: reoder data-sources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikheillomidzeq mikheillomidzeq mikheillomidzeq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anush008 @mikheillomidzeq