Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic PRs creation doesn't work (at least for me) #53

Open
mathbunnyru opened this issue Jan 1, 2021 · 17 comments
Open

Automatic PRs creation doesn't work (at least for me) #53

mathbunnyru opened this issue Jan 1, 2021 · 17 comments

Comments

@mathbunnyru
Copy link
Contributor

I tried to automatically create PR for mongo-cxx-driver.

I used this link:
https://github.com/qchateau/conan-center-index/pull/new/ccb-mongo-cxx-driver-3.6.2

When I press Create pull request button, I get the following error:
Pull request creation failed. Validation failed: You can't perform that action at this time.

Screenshot 2021-01-02 at 00 03 31

@qchateau
Copy link
Owner

qchateau commented Jan 2, 2021

It probably only work for me then, I need to check that feature from another github account properly :/

@prince-chrismc
Copy link

Ive been able to create PRs in the past and recently!

@mathbunnyru
Copy link
Contributor Author

Ive been able to create PRs in the past and recently!

Unfortunately. still doesn't work for me.

@qchateau
Copy link
Owner

That's weird, there's no magic with this feature, it's just a plain URL. If you're connected to your github account it should work I guess

@prince-chrismc
Copy link

@qchateau
Copy link
Owner

Works for me

@mathbunnyru
Copy link
Contributor Author

Try this conan-io/[email protected]:ccb-mongo-cxx-driver-3.6.2

It doesn't work as well :(

@qchateau
Copy link
Owner

Meh, I need to create a test github account

@qchateau
Copy link
Owner

Weird: conan-io/conan-center-index#4421

@ericLemanissier
Copy link
Contributor

I got the same error message as @mathbunnyru described earlier, but it worked when I modified the text of the pull request.

@qchateau
Copy link
Owner

qchateau commented Feb 9, 2021

Oh maybe that's it, it sounds like an anti spam feature of Github.
I've always modified the text, be it to set the right library name or version, or to include a footnote about CCB

@prince-chrismc
Copy link

I always check the boxes!

it sounds like an anti spam feature

👍

@mathbunnyru
Copy link
Contributor Author

Thanks @ericLemanissier, it worked for me as well.

@qchateau I think we could change the message in the PR so it always includes the package name and the new version.
This way we will make sure all the messages are a bit different and I think it will prevent GitHub from denying PRs.

@qchateau
Copy link
Owner

qchateau commented Feb 9, 2021

The initial text is the template defined by CCI, as much as I'd like to, I don't think my bot/website can change the default text

@prince-chrismc
Copy link

@mathbunnyru
Copy link
Contributor Author

The initial text is the template defined by CCI, as much as I'd like to, I don't think my bot/website can change the default text

That's true, but I think we can add some text here:

"Generated and committed by [Conan Center Bot](https://github.com/qchateau/conan-center-bot)\n"

Generated and committed by Conan Center Bot
Find more updatable recipes in the GitHub Pages

This is always in the first PR message, so I think adding info about the name of the recipe and the version won't hurt and it might resolve my issue.

@qchateau
Copy link
Owner

This is the commit message, which already contains the library name on version on its first line.
It seems by default Github uses the first line of the commit message as the PR title, and the rest of the commit message as the PR description. Then the CCI PR template is appended.

f"{recipe.name}: add version {conan_version}\n\n"
"Generated and committed by [Conan Center Bot](https://github.com/qchateau/conan-center-bot)\n"
"Find more updatable recipes in the [GitHub Pages](https://qchateau.github.io/conan-center-bot/)",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants