Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package] mongo-cxx-driver/3.6.2: this version appears twice #4415

Closed
mathbunnyru opened this issue Jan 29, 2021 · 6 comments · Fixed by #4439
Closed

[package] mongo-cxx-driver/3.6.2: this version appears twice #4415

mathbunnyru opened this issue Jan 29, 2021 · 6 comments · Fixed by #4439
Labels
bug Something isn't working

Comments

@mathbunnyru
Copy link
Contributor

@qchateau created a PR, which adds version 3.6.2 to the list of versions.

His commit was originally created 27 days ago (2 Jan 2021):
32c42a5

The PR was created 29 Jan:
#4403

But I have already added version 3.6.2 before PR was accepted on 18 Jan:
https://github.com/conan-io/conan-center-index/pull/4057/files

There was no merge error, because I added the information to the end, and hist bot added it to the beginning.

@mathbunnyru mathbunnyru added the bug Something isn't working label Jan 29, 2021
@mathbunnyru
Copy link
Contributor Author

@qchateau I think it's your bot is misbehaving, because it allowed you to create the PR for the recipe updated a while ago.

@mathbunnyru
Copy link
Contributor Author

@qchateau
Copy link
Contributor

Hey, I tried to find out what happened. Thankfully CCB keeps the history of all its statuses, but it seems that between the 18th of January and the 29th of January, the bot was correctly reporting the latest version to be "3.6.2", and did not link anymore to the branch it built on the 2nd of January.

When I opened #4403, I did it by clicking the link here qchateau/conan-center-bot#53, and not from the CCB updatable page. My guess would be that this link was not available on CCB's updatable page anymore at this time.

@mathbunnyru
Copy link
Contributor Author

My suggestion - maybe it would be helpful to delete update branches to make sure no one else makes a mistake like that.

@qchateau
Copy link
Contributor

It's a technical solution which also brings its fair share of corner cases. And to be completely honest, I don't have much free time to allocate to CCB at the moment.
On the other hand I think there is no reason for this to happen again as it is the combination of singular events:

  • There was no merge conflict
  • The bot had removed the merge "quick link" but we kept it in the comments of an issue
  • I opened the merge request without even taking a look at its content of usefulness because I was investigation a bug

@mathbunnyru
Copy link
Contributor Author

Thanks, that's a good explanation. I will create a PR to remove the version duplication, which will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants