Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] 修改是否升级成websocket判断 兼容火狐浏览器 #314

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

cuteLittleDevil
Copy link
Contributor

火狐浏览器ws请求时 Connection = [keep-alive, Upgrade]
目前是根据RFC 6455标准例子判断Connection=Upgrade
会导致火狐浏览器ws升级失败
根据RFC 2616修改为Connection包含Upgrade即可

火狐浏览器ws请求时 Connection = [keep-alive, Upgrade]
目前是根据RFC 6455标准例子判断Connection=Upgrade
会导致火狐浏览器ws升级失败
根据RFC 2616修改为Connection包含Upgrade即可
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (6af11b2) 55.95% compared to head (2263c7f) 55.92%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
- Coverage   55.95%   55.92%   -0.04%     
==========================================
  Files         132      132              
  Lines       11435    11435              
==========================================
- Hits         6399     6395       -4     
- Misses       4345     4347       +2     
- Partials      691      693       +2     
Files Changed Coverage Δ
pkg/logic/http_server_handler.go 55.81% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@q191201771 q191201771 merged commit 6915b75 into q191201771:master Aug 31, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants