Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export utility functions #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

puwelous
Copy link

No description provided.

@pzuraq
Copy link
Owner

pzuraq commented Feb 23, 2020

This looks good. I think we'll also need to rearrange the publish so that Typescript compiles files and places them in the root directory, rather than dist. This is because NPM resolution doesn't allow multiple modules to come from anywhere but the main folder containing package.json (it's dumb, I know). Alternatively, we could copy package.json into dist and publish from their I think.

If you want to add that onto this PR feel free, otherwise I'll try to get to it soon!

@puwelous
Copy link
Author

puwelous commented Mar 2, 2020

@pzuraq Well, I rebase the PR onto master to incorporate fixes from #12, unfortunately, my knowledge is insufficient in rearranging the publish.

@lukemelia
Copy link
Contributor

Excited for this to land. We've copied and pasted getPath for now. Unfortunately, I also don't know enough about typescript to help with the last task here.

@xomaczar
Copy link

Same here. Would like to see this PR getting merged, for now we've also copied/pasted getPath/setPath into our codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants