Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping black, flake8 and isort in favor of ruff #145

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Dropping black, flake8 and isort in favor of ruff #145

merged 1 commit into from
Nov 1, 2024

Conversation

tkoyama010
Copy link
Member

@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance labels Nov 1, 2024
akaszynski
akaszynski reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could remove many of those lines with ERA001, but otherwise LGTM.

@tkoyama010
Copy link
Member Author

Thank you. I would like to address the noqa part in a separate Pull Request.

@tkoyama010 tkoyama010 merged commit 0402467 into main Nov 1, 2024
10 checks passed
@tkoyama010 tkoyama010 deleted the maint/ruff-format branch November 1, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkoyama010 @akaszynski