Update the tests #2521
Closed
Update the tests #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64815497 |
Microve
added a commit
to Microve/torchrec
that referenced
this pull request
Oct 25, 2024
Summary: We updated the `torch._dynamo.config.optimize_ddp` from `python_reducer` to `python_reducer_without_compiled_forward`, which will generate different number of compiled autograd graph. This is expected. We thus update the test. Differential Revision: D64815497
Microve
force-pushed
the
export-D64815497
branch
from
fbcf9fc
to
b886d96
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64815497 |
Microve
added a commit
to Microve/torchrec
that referenced
this pull request
Oct 26, 2024
Summary: We updated the `torch._dynamo.config.optimize_ddp` from `python_reducer` to `python_reducer_without_compiled_forward`, which will generate different number of compiled autograd graph. This is expected. We thus update the test. Reviewed By: yf225 Differential Revision: D64815497
Microve
force-pushed
the
export-D64815497
branch
from
b886d96
to
7b70ab2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64815497 |
Summary: We updated the `torch._dynamo.config.optimize_ddp` from `python_reducer` to `python_reducer_without_compiled_forward`, which will generate different number of compiled autograd graph. This is expected. We thus update the test. Reviewed By: yf225 Differential Revision: D64815497
Microve
force-pushed
the
export-D64815497
branch
from
7b70ab2
to
1ef5c6b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64815497 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We updated the
torch._dynamo.config.optimize_ddpfrompython_reducertopython_reducer_without_compiled_forward, which will generate different number of compiled autograd graph. This is expected. We thus update the test.Differential Revision: D64815497