Skip to content

Commit

Permalink
c10::nullopt -> std::nullopt (#2515)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #2515

X-link: pytorch/executorch#6461

X-link: pytorch/audio#3848

X-link: pytorch/ao#1151

X-link: facebookincubator/AITemplate#1032

Reviewed By: houseroad

Differential Revision: D64835967

fbshipit-source-id: 9f9f65335aaf5497680561027ef9314e4b36f8d9
  • Loading branch information
r-barnes authored and facebook-github-bot committed Oct 23, 2024
1 parent 836d0f8 commit 7855789
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class GPUExecutor {
std::shared_ptr<IGPUExecutorObserver>
observer, // shared_ptr because used in completion executor callback
std::function<void()> warmupFn = {},
std::optional<size_t> numThreadsPerGPU = c10::nullopt,
std::optional<size_t> numThreadsPerGPU = std::nullopt,
std::unique_ptr<GCConfig> gcConfig = std::make_unique<GCConfig>());
GPUExecutor(GPUExecutor&& executor) noexcept = default;
GPUExecutor& operator=(GPUExecutor&& executor) noexcept = default;
Expand Down
2 changes: 1 addition & 1 deletion torchrec/inference/include/torchrec/inference/Validation.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace torchrec {
bool validateSparseFeatures(
at::Tensor& values,
at::Tensor& lengths,
std::optional<at::Tensor> maybeWeights = c10::nullopt);
std::optional<at::Tensor> maybeWeights = std::nullopt);

// Returns whether dense features are valid.
// Currently validates:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class GPUExecutor {
std::shared_ptr<IGPUExecutorObserver>
observer, // shared_ptr because used in completion executor callback
std::function<void()> warmupFn = {},
std::optional<size_t> numThreadsPerGPU = c10::nullopt,
std::optional<size_t> numThreadsPerGPU = std::nullopt,
std::unique_ptr<GCConfig> gcConfig = std::make_unique<GCConfig>());
GPUExecutor(GPUExecutor&& executor) noexcept = default;
GPUExecutor& operator=(GPUExecutor&& executor) noexcept = default;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace torchrec {
bool validateSparseFeatures(
at::Tensor& values,
at::Tensor& lengths,
std::optional<at::Tensor> maybeWeights = c10::nullopt);
std::optional<at::Tensor> maybeWeights = std::nullopt);

// Returns whether dense features are valid.
// Currently validates:
Expand Down

0 comments on commit 7855789

Please sign in to comment.