Skip to content

Commit

Permalink
Update validate_binaries to include python 3.12, cu124, and pypi (#2505)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #2505

Previously, validate_binaries did not cover python 3.12, cu124, nor pypi. This upgrade allows us to cover those use cases, which are vital to the OSS health.

Reviewed By: iamzainhuda

Differential Revision: D64762917

fbshipit-source-id: 345eab0699a11e85810312bfa2b3faad8619759a
  • Loading branch information
PaulZhang12 authored and facebook-github-bot committed Oct 22, 2024
1 parent 3d08f7b commit 0bf9802
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
11 changes: 4 additions & 7 deletions .github/scripts/validate_binaries.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,8 @@ if [[ ${MATRIX_GPU_ARCH_TYPE} = 'rocm' ]]; then
exit 0
fi

if [[ ${MATRIX_PYTHON_VERSION} = '3.12' ]]; then
echo "Temporarily disable validation for Python 3.12"
exit 0
fi

if [[ ${MATRIX_GPU_ARCH_TYPE} = 'cuda' ]]; then
export CUDA_VERSION="cu118"
export CUDA_VERSION="cu124"
else
export CUDA_VERSION="cpu"
fi
Expand All @@ -36,8 +31,10 @@ fi
if [[ ${MATRIX_GPU_ARCH_TYPE} = 'cuda' ]]; then
if [[ ${MATRIX_GPU_ARCH_VERSION} = '11.8' ]]; then
export CUDA_VERSION="cu118"
else
elif [[ ${MATRIX_GPU_ARCH_VERSION} = '12.1' ]]; then
export CUDA_VERSION="cu121"
else
export CUDA_VERSION="cu124"
fi
else
export CUDA_VERSION="cpu"
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/validate-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,14 @@ on:
workflow_dispatch:
inputs:
channel:
description: "Channel to use (nightly, release, test)"
description: "Channel to use (nightly, release, test, pypi)"
required: true
type: choice
options:
- release
- nightly
- test
- pypi_release
ref:
description: 'Reference to checkout, defaults to empty'
default: ""
Expand Down

0 comments on commit 0bf9802

Please sign in to comment.