Skip to content

Commit

Permalink
DCP checkpoint restore backward compatibility in TorchTNT (#898)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #898

 DCP checkpoint restore backward compatibility. Current implementation assumes the checkpoint to be a ModelStore Checkpoint. There are customers who are using DCP saver with path based checkpoint id.

Reviewed By: JKSenthil

Differential Revision: D62542227
  • Loading branch information
saumishr authored and facebook-github-bot committed Sep 12, 2024
1 parent 79a0698 commit e316246
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 0 deletions.
20 changes: 20 additions & 0 deletions tests/utils/test_checkpoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -1308,6 +1308,26 @@ def test_metadata_exists(self) -> None:
os.remove(os.path.join(dirpath, SNAPSHOT_METADATA_FNAME))
self.assertFalse(_metadata_exists(fs, dirpath, SNAPSHOT_METADATA_FNAME))

def test_does_checkpoint_metadata_exist(self) -> None:
app_state = {"module": nn.Linear(2, 2)}

with tempfile.TemporaryDirectory() as temp_dir:
dirpath = os.path.join(temp_dir, "checkpoint")
Snapshot.take(dirpath, app_state=app_state)

self.assertTrue(
CheckpointManager.does_checkpoint_metadata_exist(
dirpath, SNAPSHOT_METADATA_FNAME
)
)

os.remove(os.path.join(dirpath, SNAPSHOT_METADATA_FNAME))
self.assertFalse(
CheckpointManager.does_checkpoint_metadata_exist(
dirpath, SNAPSHOT_METADATA_FNAME
)
)


class MyValLossUnit(TrainUnit[Batch]):
def __init__(self) -> None:
Expand Down
12 changes: 12 additions & 0 deletions torchtnt/utils/checkpoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,18 @@ def does_checkpoint_exist(
_metadata_exists(fs, ckpt.path, fname) for fname in self._metadata_fnames
)

@staticmethod
def does_checkpoint_metadata_exist(
checkpoint_path: str,
metadata_fname: str,
) -> bool:
"""
Checking whether a checkpoint metadata file exists in the directory.
If the checkpointer has that metadata file, this function will returns True. Returns False otherwise.
"""
fs, _ = url_to_fs(checkpoint_path)
return _metadata_exists(fs, checkpoint_path, metadata_fname)

@staticmethod
@rank_zero_read_and_broadcast
def _sync_dirpath_to_all_ranks(
Expand Down

0 comments on commit e316246

Please sign in to comment.