Skip to content

Commit

Permalink
add number of steps in prev epoch to progress (#873)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #873

Expose number of steps in prev completed epoch

Reviewed By: diego-urgell

Differential Revision: D60309756

fbshipit-source-id: 8d356f2b4cba4e5e74ad16fa24935864b0f30ea6
  • Loading branch information
galrotem authored and facebook-github-bot committed Jul 29, 2024
1 parent e4e7a9d commit cab6afc
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 0 deletions.
14 changes: 14 additions & 0 deletions tests/utils/test_progress.py
Original file line number Diff line number Diff line change
Expand Up @@ -286,3 +286,17 @@ def __iter__(self) -> Iterator[int]:
),
float("inf"),
)

def test_num_steps_completed_in_prev_epoch(self) -> None:
progress = Progress(
num_epochs_completed=2,
num_steps_completed=8,
num_steps_completed_in_epoch=4,
)
self.assertEqual(progress.num_steps_completed_in_epoch, 4)
self.assertEqual(progress.num_steps_completed_in_prev_epoch, 0)

progress.increment_epoch()

self.assertEqual(progress.num_steps_completed_in_epoch, 0)
self.assertEqual(progress.num_steps_completed_in_prev_epoch, 4)
7 changes: 7 additions & 0 deletions torchtnt/utils/progress.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ def __init__(
self._num_epochs_completed: int = num_epochs_completed
self._num_steps_completed: int = num_steps_completed
self._num_steps_completed_in_epoch: int = num_steps_completed_in_epoch
self._num_steps_completed_in_prev_epoch: int = 0

@property
def num_epochs_completed(self) -> int:
Expand All @@ -38,6 +39,11 @@ def num_steps_completed_in_epoch(self) -> int:
"""Number of steps completed thus far in epoch."""
return self._num_steps_completed_in_epoch

@property
def num_steps_completed_in_prev_epoch(self) -> int:
"""Number of steps completed in the previous completed epoch."""
return self._num_steps_completed_in_prev_epoch

def increment_step(self) -> None:
"""Increment the step counts completed and completed within the epoch."""
self._num_steps_completed += 1
Expand All @@ -46,6 +52,7 @@ def increment_step(self) -> None:
def increment_epoch(self) -> None:
"""Increment the epochs completed and resets the steps completed within the epoch."""
self._num_epochs_completed += 1
self._num_steps_completed_in_prev_epoch = self._num_steps_completed_in_epoch
self._num_steps_completed_in_epoch = 0

def state_dict(self) -> Dict[str, Any]:
Expand Down

0 comments on commit cab6afc

Please sign in to comment.