Skip to content

Commit

Permalink
[Versioning] windows build - add legacy back and .bat env-script (#2339)
Browse files Browse the repository at this point in the history
  • Loading branch information
vmoens committed Jul 30, 2024
1 parent bf91ff6 commit da89826
Show file tree
Hide file tree
Showing 3 changed files with 107 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/scripts/version_script.bat
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
@echo off
set TORCHRL_BUILD_VERSION=0.5.0
echo TORCHRL_BUILD_VERSION is set to %TORCHRL_BUILD_VERSION%
1 change: 1 addition & 0 deletions .github/workflows/build-wheels-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,4 @@ jobs:
smoke-test-script: ${{ matrix.smoke-test-script }}
trigger-event: ${{ github.event_name }}
pre-script: .github/scripts/td_script.sh
env-script: .github/scripts/version_script.bat
103 changes: 103 additions & 0 deletions .github/workflows/wheels-legacy.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
name: Wheels
on:
pull_request:
types: [opened, synchronize, reopened]
push:
branches:
- release/*

concurrency:
# Documentation suggests ${{ github.head_ref }}, but that's only available on pull_request/pull_request_target triggers, so using ${{ github.ref }}.
# On master, we want all builds to complete even if merging happens faster to make it easier to discover at which point something broke.
group: ${{ github.workflow }}-${{ github.ref == 'refs/heads/main' && format('ci-master-{0}', github.sha) || format('ci-{0}', github.ref) }}
cancel-in-progress: true

jobs:

build-wheel-windows:
runs-on: windows-latest
strategy:
matrix:
python_version: [["3.8", "3.8"], ["3.9", "3.9"], ["3.10", "3.10.3"], ["3.11", "3.11"], ["3.12", "3.12"]]
steps:
- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python_version[1] }}
- name: Checkout torchrl
uses: actions/checkout@v2
- name: Install PyTorch RC
shell: bash
run: |
python3 -mpip install torch --index-url https://download.pytorch.org/whl/cpu
- name: Build wheel
shell: bash
run: |
python3 -mpip install wheel
TORCHRL_BUILD_VERSION=0.5.0 python3 setup.py bdist_wheel
- name: Upload wheel for the test-wheel job
uses: actions/upload-artifact@v2
with:
name: torchrl-win-${{ matrix.python_version[0] }}.whl
path: dist/torchrl-*.whl
- name: Upload wheel for download
uses: actions/upload-artifact@v2
with:
name: torchrl-batch.whl
path: dist/*.whl

test-wheel-windows:
needs: build-wheel-windows
strategy:
matrix:
python_version: [ "3.8", "3.9", "3.10", "3.11", "3.12" ]
runs-on: windows-latest
steps:
- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python_version }}
- name: Checkout torchrl
uses: actions/checkout@v2
- name: Install PyTorch RC
shell: bash
run: |
python3 -mpip install torch torchvision --index-url https://download.pytorch.org/whl/cpu
- name: Upgrade pip
shell: bash
run: |
python3 -mpip install --upgrade pip
- name: Install tensordict
shell: bash
run: |
python3 -mpip install git+https://github.com/pytorch/tensordict.git
- name: Install test dependencies
shell: bash
run: |
python3 -mpip install numpy pytest pytest-cov codecov unittest-xml-reporting pillow>=4.1.1 scipy av networkx expecttest pyyaml
- name: Download built wheels
uses: actions/download-artifact@v2
with:
name: torchrl-win-${{ matrix.python_version }}.whl
path: wheels
- name: Install built wheels
shell: bash
run: |
python3 -mpip install wheels/*
- name: Log version string
shell: bash
run: |
# Avoid ambiguity of "import torchrl" by deleting the source files.
rm -rf torchrl/
python -c "import torchrl; print(torchrl.__version__)"
- name: Run tests
shell: bash
run: |
set -e
export IN_CI=1
mkdir test-reports
python -m torch.utils.collect_env
python -c "import torchrl; print(torchrl.__version__)"
EXIT_STATUS=0
pytest test/smoke_test.py -v --durations 200
exit $EXIT_STATUS

1 comment on commit da89826

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'CPU Benchmark Results'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: da89826 Previous: bf91ff6 Ratio
benchmarks/test_replaybuffer_benchmark.py::test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 302.2136685804384 iter/sec (stddev: 0.014985135925413277) 748.1416236874735 iter/sec (stddev: 0.0005938960529856714) 2.48

This comment was automatically generated by workflow using github-action-benchmark.

CC: @vmoens

Please sign in to comment.