Remove uwsgi from application dependencies #682
Conversation
uwsgi is installed by default using other means in the virtualenv used by junction. There is no need to install uwsgi through the application dependencies. The support for uwsgi is flaky at best on Windows and works with very limited functionality. Hence, this breaks development velocity for people developing Junction on Windows. Ref: pythonindia#651 Signed-off-by: Nabarun Pal <[email protected]>
|
Closing and reopening for satisfying Travis CI. 😞 |
|
Just a wild guess, but won't squashing an empty commit also trigger the CI? |
|
@sayanchowdhury -- It should even if I amend the commits and force push. The problem is with Travis CI not even getting the events. 🤷♂️ |
|
Hmm, weird. |
|
@palnabarun I think it will be good to move this to a separate |
Well, uwsgi is going to go away soon in the new setup. uwsgi is not related to the Junction application and should not be there in the project at all. |
|
Isn't uswgi needed in production ? |
Yes. It is, but not installed using this project's requirements. |
|
Well it's good to have a separate prod-requirements.txt than to manually install production packages |
|
Keeping all dependencies in requirements.txt for now to ease dev and prod installs. |
uwsgi is installed by default using other means in the virtualenv
used by junction. There is no need to install uwsgi through the
application dependencies.
The support for uwsgi is flaky at best on Windows and works with
very limited functionality. Hence, this breaks development velocity
for people developing Junction on Windows.
Ref: #651
Closes #651