make request token method Trelll compatible #832
Conversation
| @@ -247,7 +247,8 @@ def request_token_extra_arguments(self): | |||
| def unauthorized_token(self): | |||
| """Return request for unauthorized token (first stage)""" | |||
| params = self.request_token_extra_arguments() | |||
| params.update(self.get_scope_argument()) | |||
| if self.name not in ['trello']: | |||
| params.update(self.get_scope_argument()) | |||
There was a problem hiding this comment.
If this is really needed, overriding get_scope_argument in TrelloOAuth is the way to go.
There was a problem hiding this comment.
Trello REQUEST_TOKEN_URL (https://trello.com/1/OAuthGetRequestToken) does not take any arguments.
If we send the scope here then the URL looks like this https://trello.com/1/OAuthGetRequestToken?scope=read,write
As per above mentioned Trello request does not take any arguments in REQUEST_TOKEN_URL. Trello gives an error like this...
ERROR: 400 Client Error: Bad Request for URL: https://trello.com/1/OAuthGetRequestToken?scope=read%2Cwrite
There was a problem hiding this comment.
Thanks, this should go as a comment to the code. And the implementation should override get_scope_argument method in TrelloOAuth instead of doing changes in generic OAuth backend.
bs-bhagirath-radadiya
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #832 +/- ##
==========================================
- Coverage 77.11% 77.11% -0.01%
==========================================
Files 337 337
Lines 10262 10263 +1
Branches 690 691 +1
==========================================
Hits 7914 7914
Misses 2192 2192
- Partials 156 157 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Closing as review feedback was not addressed. |
if social auth for Trello then scope arguments are not getting for the request token method