Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recalculate authenticated user on complete #651

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Recalculate authenticated user on complete #651

wants to merge 4 commits into from

Commits on Jan 5, 2022

  1. Check whether user is still authenticated just after pipeline ends 

    We check if the user is authenticated before the pipeline runs but the structure of the pipeline allows for the user instance to change as the pipeline runs. We don't re-check whether the user is still authenticated before working out whether or not to log them in!
    Ben Rogers-Newsome committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    a8a773e View commit details
    Browse the repository at this point in the history

  2. Better variable naming for user in complete 

    The user variable was being re-assigned based on itself multiple times. In reality there are 3 variables here: The user we pass to the function, the user we pass into the pipeline and the user we get back out of the pipeline. These are 3 separate variables (it just so happens that we don't care about the old one once we create the new one). Separating the variables out into three makes it much clearer what is going on with the pipeline.

Made a similar name change for the added user_authenticated variable.
    Ben Rogers-Newsome committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    a65bd7e View commit details
    Browse the repository at this point in the history

  3. Updated CHANGELOG.md

    Ben Rogers-Newsome committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    1c072db View commit details
    Browse the repository at this point in the history

  4. Updated tests 

    All tests were assuming that the user was authenticated, which caused
tests to fail now that we are actually checking that the user is authenticated
post-pipeline (a none user is obviously not authenticated so pre-pipeline this
wasn't causing problems).

Mirrored the way that is_active is done.
    Ben Rogers-Newsome committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    928431d View commit details
    Browse the repository at this point in the history