-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix complicated export case #5711
Conversation
d261745
to
afc2e4a
Compare
What I don't like is that there seems to be no usage and no test for |
afc2e4a
to
5f421b1
Compare
This is of course blocked on there being a poetry-core that provides I've made an additional fix along the way though, to tighten up the code that selects a locked package so that it never can choose overlaps
|
243573b
to
5cc68a1
Compare
9e9c32c
to
283f2e5
Compare
By treating different python version ranges independently, we buy the flexibility needed to make better decisions.
fail more visibly if we take a wrong turn
releases of poetry-core makes this ready to merge; but it's hard to negotiate the trip hazards set up by the cross-repository testing in the workflows. The workflow identifies that this is "breaking" the released version of the plugin; though it's really fixing it. python-poetry/poetry-plugin-export#68 is the corresponding UT change. |
Some notes on disentangling the cross-repository mess in #5980 (comment) TLDR suggest moving all the remaining export-specific code over to the export plugin. That would put the code and its tests in the same place, which seems much more sensible. |
This should be ready to merge, modulo "what do we do about cross-repository testing". |
Superseded by: python-poetry/poetry-plugin-export#94 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Related to python-poetry/poetry-core#381 (on which, as currently written, it relies) and python-poetry/poetry-plugin-export#32.
I don't yet have a testcase proving the point for poetry-export-plugin, but will get there eventually...