Feed Dovecot maildir stats into Prometheus #505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group: ansible
jb3
requested changes
Aug 26, 2024
| - name: Report to DevOps when Maildir size exporter fails | ||
| ansible.builtin.cron: | ||
| name: MAILTO | ||
| env: yes |
There was a problem hiding this comment.
Ansible Lint is complaining about this line:
Suggested change
| env: yes | |
| env: true |
jb3
requested changes
Aug 26, 2024
There was a problem hiding this comment.
Another minor thing with this: the dovecot_maildir_size_bytes metric is not actually exposing bytes, it's exposing kilobytes, on account of the fact that du, by default, outputs units of 1024 bytes:
joe@lovelace:~$ sudo du -s /var/vmail/joe
5260 /var/vmail/joe
joe@lovelace:~$ sudo du -sh /var/vmail/joe
5.2M /var/vmail/joe
|
Grafana dash for email: https://grafana.pydis.wtf/d/edw0wuqz1yccgf/email?orgId=2 |
jchristgit
force-pushed
the
dovecot-prometheus-stats
branch
from
fb25251
to
22af8a7
Compare
|
Thanks for the review, script has been adjusted to use `--bytes` (how do
you already use 5 MB for your maildir?) and YAML dictator should be
pleased.
|
Already deployed on lovelace. I was going to leave out script deployment and just write it inline, but YAML folding of long lines (and unreadability of 200 column-wide AWk scripts, to be honest) made it a bit bad. The e-mail for DevOps cron failure reports is updated to include `+cron` to allow for client-side filtering, if necessary. To test: `ssh -L localhost:9090:localhost:9090 lovelace.box.pydis.wtf`, then check out the `dovecot_` variables in the UI. We might want to further check out Dovecot's built-in statistics support, see https://doc.dovecot.org/2.3/configuration_manual/stats/.
jchristgit
force-pushed
the
dovecot-prometheus-stats
branch
from
22af8a7
to
dfb87d1
Compare
jb3
approved these changes
Aug 30, 2024
|
Merged into main. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already deployed on lovelace. I was going to leave out script deployment
and just write it inline, but YAML folding of long lines (and
unreadability of 200 column-wide AWk scripts, to be honest) made it a
bit bad.
The e-mail for DevOps cron failure reports is updated to include
+cronto allow for client-side filtering, if necessary.
To test:
ssh -L localhost:9090:localhost:9090 lovelace.box.pydis.wtf,then check out the
dovecot_variables in the UI.We might want to further check out Dovecot's built-in statistics
support, see https://doc.dovecot.org/2.3/configuration_manual/stats/.