Adding an option to turn off derivatives of values for bind collector #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortdudey123
requested changes
Dec 16, 2016
| @@ -32,6 +32,7 @@ publish | resolver, server, zonemgmt, sockets, memory, | Available stats:<br> | |||
| | list | |||
There was a problem hiding this comment.
Mode change???
100644 → 100755
| @@ -32,6 +32,7 @@ publish | resolver, server, zonemgmt, sockets, memory, | Available stats:<br> | |||
| | list | |||
| publish_view_bind | False | | bool | |||
| publish_view_meta | False | | bool | |||
| derivative | True | Report derived stats or raw (always incrementing) | bool | |||
There was a problem hiding this comment.
This should be auto-generated from get_default_config, not manually edited
There was a problem hiding this comment.
Sorry, not familiar with this - Can you give me a pointer?
There was a problem hiding this comment.
2 ways you can fix it:
- use
build_doc.py - alphabetize and add the same exact text to the
get_default_configfunction in the code
| @@ -63,13 +64,15 @@ def get_default_config(self): | |||
| # By default we don't publish these special views | |||
| 'publish_view_bind': False, | |||
| 'publish_view_meta': False, | |||
| 'derivative': True, | |||
There was a problem hiding this comment.
Need to add this to get_default_config as well
means you can use graphite derivative or perSecond functions to get more accurate values over time
thardie
force-pushed
the
bind9-derivative
branch
from
7fba35b
to
ed8e3cd
Compare
|
last thing: alphabetize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means you can use graphite derivative or perSecond functions to get more accurate values over time