Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EqualizeMessenger type annotations #3401

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+4 −1
Open

Fix EqualizeMessenger type annotations #3401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pyro/poutine/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,14 +306,16 @@ def escape( # type: ignore[empty-body]
def equalize(
sites: Union[str, List[str]],
type: Optional[str],
) -> ConditionMessenger: ...
keep_dist: Optional[bool],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keep_dist should have just a bool type, right? It should have the same type as in the EqualizeMessenger class definition.

) -> EqualizeMessenger: ...


@overload
def equalize(
fn: Callable[_P, _T],
sites: Union[str, List[str]],
type: Optional[str],
keep_dist: Optional[bool],
) -> Callable[_P, _T]: ...


Expand All @@ -322,6 +324,7 @@ def equalize( # type: ignore[empty-body]
fn: Callable[_P, _T],
sites: Union[str, List[str]],
type: Optional[str],
keep_dist: Optional[bool],
) -> Union[EqualizeMessenger, Callable[_P, _T]]: ...


Expand Down
Loading