Drop old ipy engines #2094
Merged
Drop old ipy engines #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You want to use which base branch @sanzoghenzo ? |
|
Thanks for the pointer @jmcouffin, I always forget to set the right branch 😅 I did the work on the develop branch as decided on #2087, but I can also apply it to version 4 |
|
I'd say both, yes please |
|
Would you mind trying the installer for the dev 4 branch? @sanzoghenzo |
|
📦 New public release are available for 4.8.16.24121+2117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the old IronPython engines, leaving only 2.7.11 and 3.4.0.
Note that building the installer fails due to the missing runtime csharp files (moved by 584eda7).
I also added a workflow to do the build only (
pyrevit build products) on forks (so that we can ensure everything compiles before submitting a PR).