Merge pull request #1870 from thumDer/develop

hotfix for geometry query
pyrevitlabs · Jul 14, 2023 · f793e9e · f793e9e
2 parents 96abf97 + f82d075
commit f793e9e
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/pyrevitlib/pyrevit/revit/db/query.py b/pyrevitlib/pyrevit/revit/db/query.py
@@ -1576,10 +1576,14 @@ def get_geometry(element, include_invisible=False, compute_references=False):
     geom_opts.IncludeNonVisibleObjects = include_invisible
     geom_opts.ComputeReferences = compute_references
     geom_objs = []
-    for gobj in element.Geometry[geom_opts]:
-        if isinstance(gobj, DB.GeometryInstance):
-            inst_geom = gobj.GetInstanceGeometry()
-            geom_objs.extend(list(inst_geom))
-        else:
-            geom_objs.append(gobj)
-    return geom_objs
+    try:
+        for gobj in element.Geometry[geom_opts]:
+            if isinstance(gobj, DB.GeometryInstance):
+                inst_geom = gobj.GetInstanceGeometry()
+                geom_objs.extend(list(inst_geom))
+            else:
+                geom_objs.append(gobj)
+        return geom_objs
+    except TypeError:
+        mlogger.debug("element %s has no geometry", element.Id.IntegerValue)
+        return