Merge pull request #2395 from pyrevitlabs/fix/2333

Update ScriptConsole.cs
pyrevitlabs · Sep 10, 2024 · 5fcc710 · 5fcc710
2 parents 372cc6c + cae17c1
commit 5fcc710
Showing 1 changed file with 37 additions and 9 deletions.
diff --git a/dev/pyRevitLabs.PyRevit.Runtime/ScriptConsole.cs b/dev/pyRevitLabs.PyRevit.Runtime/ScriptConsole.cs
@@ -834,17 +834,31 @@ private System.Windows.Shapes.Path GetAutoCollapseIcon(bool active) {
                 return MakeButtonPath("M19.92,12.08L12,20L4.08,12.08L5.5,10.67L11,16.17V2H13V16.17L18.5,10.66L19.92,12.08M12,20H2V22H22V20H12Z");
         }
 
-        private void Save_Contents_Button_Clicked(object sender, RoutedEventArgs e) {
-            var saveDlg = new System.Windows.Forms.SaveFileDialog() {
+        private void Save_Contents_Button_Clicked(object sender, RoutedEventArgs e)
+        {
+            var saveDlg = new System.Windows.Forms.SaveFileDialog()
+            {
                 Title = "Save Output to:",
-                Filter = "HTML|*.html"
+                Filter = "HTML Files|*.html",
+                DefaultExt = "html",
+                AddExtension = true,
+                RestoreDirectory = true
             };
-            saveDlg.ShowDialog();
-            var f = File.CreateText(saveDlg.FileName);
-            f.Write(GetFullHtml());
-            f.Close();
+            if (saveDlg.ShowDialog() != System.Windows.Forms.DialogResult.OK || string.IsNullOrWhiteSpace(saveDlg.FileName))
+            {
+                return;
+            }
+            try
+            {
+                using (File.CreateText(saveDlg.FileName).Write(GetFullHtml())) { }
+            }
+            catch (Exception ex)
+            {
+                System.Windows.MessageBox.Show($"Error saving file: {ex.Message}", "Save Error", MessageBoxButton.OK, MessageBoxImage.Error);
+            }
         }
 
+
         private void PinButton_Click(object sender, RoutedEventArgs e) {
             var button = e.Source as Button;
             if (Topmost) {
@@ -901,8 +915,22 @@ private string SaveContentsToTemp() {
             return tempHtml;
         }
 
-        private void OpenButton_Click(object sender, RoutedEventArgs e) {
-            Process.Start(string.Format("file:///{0}", SaveContentsToTemp()));
+        private void OpenButton_Click(object sender, RoutedEventArgs e)
+        {
+            try
+            {
+                var uri = new Uri(SaveContentsToTemp()).AbsoluteUri;
+                var processInfo = new ProcessStartInfo()
+                {
+                    FileName = uri,
+                    UseShellExecute = true
+                };
+                Process.Start(processInfo);
+            }
+            catch (Exception ex)
+            {
+                System.Windows.MessageBox.Show($"Error opening file: {ex.Message}", "Open Error", MessageBoxButton.OK, MessageBoxImage.Error);
+            }
         }
 
         private void PrintButton_Click(object sender, RoutedEventArgs e) {