Skip to content

Commit

Permalink
Bump version: 72.1.0 → 72.2.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@jaraco
jaraco committed Aug 2, 2024
1 parent 780a782 commit 76942cf
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .bumpversion.cfg
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 72.1.0
current_version = 72.2.0
commit = True
tag = True

Expand Down
9 changes: 9 additions & 0 deletions NEWS.rst
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
v72.2.0
=======

Features
--------

- Merged with pypa/distutils@b7ee725f3 including: Support for Pathlike objects in data files and extensions (pypa/distutils#272, pypa/distutils#237), native support for C++ compilers (pypa/distuils#228) and removed unused get_msvcr() (pypa/distutils#274). (#4538)


v72.1.0
=======

Expand Down
1 change: 0 additions & 1 deletion newsfragments/4538.feature.rst
View file

This file was deleted.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ backend-path = ["."]

[project]
name = "setuptools"
version = "72.1.0"
version = "72.2.0"
authors = [
{ name = "Python Packaging Authority", email = "[email protected]" },
]
Expand Down

2 comments on commit 76942cf

@abravalheri
Copy link
Contributor

@abravalheri abravalheri commented on 76942cf Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this tag never got published to PyPI due to a failure in the integration tests.

The brotli package fails to build with the error:

Traceback (most recent call last):
        File "/tmp/pytest-of-runner/pytest-0/popen-gw2/test_install_sdist_brotli_v_LA0/.venv/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/tmp/pytest-of-runner/pytest-0/popen-gw2/test_install_sdist_brotli_v_LA0/.venv/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/tmp/pytest-of-runner/pytest-0/popen-gw2/test_install_sdist_brotli_v_LA0/.venv/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
          return hook(metadata_directory, config_settings)
        File "/tmp/pytest-of-runner/pytest-0/popen-gw2/test_install_sdist_brotli_v_LA0/.venv/lib/python3.10/site-packages/setuptools/build_meta.py", line 368, in prepare_metadata_for_build_wheel
          self.run_setup()
        File "/tmp/pytest-of-runner/pytest-0/popen-gw2/test_install_sdist_brotli_v_LA0/.venv/lib/python3.10/site-packages/setuptools/build_meta.py", line 313, in run_setup
          exec(code, locals())
        File "<string>", line 282, in <module>
        File "/tmp/pytest-of-runner/pytest-0/popen-gw2/test_install_sdist_brotli_v_LA0/.venv/lib/python3.10/site-packages/setuptools/__init__.py", line 108, in setup
          return distutils.core.setup(**attrs)
        File "/tmp/pytest-of-runner/pytest-0/popen-gw2/test_install_sdist_brotli_v_LA0/.venv/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 146, in setup
          _setup_distribution = dist = klass(attrs)
        File "/tmp/pytest-of-runner/pytest-0/popen-gw2/test_install_sdist_brotli_v_LA0/.venv/lib/python3.10/site-packages/setuptools/dist.py", line 278, in __init__
          _Distribution.__init__(self, dist_attrs)
        File "/tmp/pytest-of-runner/pytest-0/popen-gw2/test_install_sdist_brotli_v_LA0/.venv/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 286, in __init__
          self.finalize_options()
        File "/tmp/pytest-of-runner/pytest-0/popen-gw2/test_install_sdist_brotli_v_LA0/.venv/lib/python3.10/site-packages/setuptools/dist.py", line 630, in finalize_options
          ep(self)
        File "/tmp/pytest-of-runner/pytest-0/popen-gw2/test_install_sdist_brotli_v_LA0/.venv/lib/python3.10/site-packages/setuptools/dist.py", line 650, in _finalize_setup_keywords
          ep.load()(self, ep.name, value)
        File "/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/importlib/metadata/__init__.py", line [173](https://github.com/pypa/setuptools/actions/runs/10222324185/job/28287095585#step:6:174), in load
          return functools.reduce(getattr, attrs, module)
      AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'

I suspect there might be an outdated *.egg-info/entrypoints.txt or *.dist-info/entrypoints.txt somewhere in sys.path of the CI worker?

In my local test I can see that there is a /tmp/pytest-of-abravalheri/pytest-155/test_install_sdist_brotli_v_LA0/.venv/lib/python3.11/site-packages/setuptools-70.3.0.dist-info file in the generated virtual environment for some reason. Isn't the -I option in pip install supposed to prevent this from happening?

Other information relevant is that Brotli also uses the removed test_suite option.

@jaraco
Copy link
Member Author

@jaraco jaraco commented on 76942cf Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to recall having experienced this in a different release as well... and I think I re-ran the integration tests and they succeeded on the second run. Looking at https://github.com/pypa/setuptools/actions/runs/10146616001, it was run just once, so not that one? I think it was https://github.com/pypa/setuptools/actions/runs/10134752619, in particular attempt 1.

Aha, yes. I reported the issue in #4518, but it went off topic and I assumed the issue was transient (not intermittent).

I see now you've filed #4564 and addressed the issue I'll take the discussion there.

Please sign in to comment.