Prevent breakage from vcs URL in lockfile from having package name @ #6302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteius
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this in the CI and my checks, but the pypi release CI caught it and prevented release thankfully -- there was an edge cases with vcs dependencies in upgrade path.
I'm not sure that it covers 100% of what someone might want out of upgrade command, because I think you need to specify what you need upgrade in the CLI, or it behaves quite similar to a regular install. We can iterate on this, mostly wanted to unblock CIs that were broken by update requiring an existing lockfile.