Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ! instead . to make "--break-system-package" clickable #12899

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elsamuko
Copy link

@elsamuko elsamuko commented Aug 6, 2024

This PR changes the . as last character to !, because then I can double-click-select --break-system-package without the ..

Workflow:

  • I want to install a pip
  • pip complains:
note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
  • I double click on --break-system-packages.
  • I paste it with center mouse button
  • I remove the . <-- the PR saves this step
  • I install the package

@elsamuko
Copy link
Author

elsamuko commented Aug 6, 2024

PS: I did not create a NEWS entry, because this is a very minor fix. How do I add a no-news-marker?

@uranusjr
Copy link
Member

uranusjr commented Aug 7, 2024

This looks more like a bug in your terminal emulator, not a thing worth changing in the code base TBH.

@elsamuko
Copy link
Author

elsamuko commented Aug 7, 2024

@uranusjr This is the default behaviour at least in

  • guake
  • xfce4-terminal
  • gnome-terminal
  • konsole
  • terminator
  • tilix
  • tilda
  • cool-retro-term
  • alacritty

So this fix would be nice for users of these terminal emulators.

@pfmoore
Copy link
Member

pfmoore commented Aug 7, 2024

An exclamation mark gives the message a different meaning, which I don't think we should do. And (at least on Windows Terminal) double clicking includes the ! just as much as it includes the .. In any case, I agree with @uranusjr - take this up with your terminal emulator developers if you don't like this behaviour. It's not like other applications use options that end with a dot, so this would be just as much of an issue everywhere. Personally, in situations like this, I either select using a mouse drag, or double click and then delete the extra charater when I paste. It's really not that hard.

Also, the message isn't intended for easy copy/paste. It's explicitly saying this is a bad thing to do - why should we make it easy to do it anyway?

@elsamuko
Copy link
Author

elsamuko commented Aug 7, 2024

Hm, instead of the !, a . or a ; could be used too.

I thought that it would make it easier to try out a python module, even if it can mess with the python installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants