Skip to content

Commit

Permalink
Setuptools now implements proper normalization
Browse files Browse the repository at this point in the history
  • Loading branch information
uranusjr committed Sep 12, 2023
1 parent 0db5d95 commit c94d81a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 12 deletions.
12 changes: 1 addition & 11 deletions tests/functional/test_install_extras.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,17 +159,7 @@ def test_install_fails_if_extra_at_end(
"specified_extra, requested_extra",
[
("Hop_hOp-hoP", "Hop_hOp-hoP"),
pytest.param(
"Hop_hOp-hoP",
"hop-hop-hop",
marks=pytest.mark.xfail(
reason=(
"matching a normalized extra request against an"
"unnormalized extra in metadata requires PEP 685 support "
"in packaging (see pypa/pip#11445)."
),
),
),
("Hop_hOp-hoP", "hop-hop-hop"),
("hop-hop-hop", "Hop_hOp-hoP"),
],
)
Expand Down
3 changes: 2 additions & 1 deletion tests/requirements-common_wheels.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
# 4. Replacing the `setuptools` entry below with a `file:///...` URL
# (Adjust artifact directory used based on preference and operating system)

setuptools >= 40.8.0, != 60.6.0
# Implements new extra normalization.
setuptools >= 68.2
wheel
# As required by pytest-cov.
coverage >= 4.4

0 comments on commit c94d81a

Please sign in to comment.