-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CPython 3.13 --disable-gil
build
#1564
Conversation
--disable-gil
)--disable-gil
build
7444855
to
2dafd58
Compare
follow-up on your request to add support for free-threaded builds to cibuildwheel: |
I think it would be pretty reasonable to use the beta on 3.13 only. I don't think there's an environment selector for free threaded? I'd prefer not to differentiate on free threaded if there's no environment selector for it. |
Why is setuptools/wheel on 3.12, actually? |
As mentioned in the commit message, it shouldn't be there & perhaps especially for python 3.12 where it's not part of |
I didn't see the description, good. I expect after 3.13 is out for a while, it probably can be removed safely from 3.12 too. |
We should probably remove this on other python versions but since it's been there for quite some time, keep them to prevent regressions downstream.
I'd have liked that too but we also have the other part of the packaging upgrade affecting us in this release: https://pradyunsg.me/blog/2024/05/13/pip-24-1-betas/. Due to some non-public health issues on my part, the actual process and comms around this haven't gone through as smoothly/effectively as I'd like. 😅 |
Thanks for the feedback @pradyunsg ! I'll merge without waiting for the final release then. FYI, pip 24.1b1 can install properly free-threaded wheels now (there's a minimal build / install test here). It also fixes issues with graalpy (c.f. #1520) but this one will have to wait for the final release. |
In case people are trying this out, |
Ouch, this may include isolated builds. Edit: most cases seem okay. |
fix #1548
draft while blocked by:
packaging
to 22.0+ pip#11715Release 24.1 pip#12613edit: we will use 24.1b1 for python 3.13 for now