Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use armv7l policy for 64-bit arm kernel in 32-bit mode (armv8l) #419

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Apr 10, 2023

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (0dd24f0) 92.31% compared to head (79ae584) 92.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   92.31%   92.33%   +0.01%     
==========================================
  Files          23       23              
  Lines        1289     1291       +2     
  Branches      301      302       +1     
==========================================
+ Hits         1190     1192       +2     
  Misses         57       57              
  Partials       42       42              
Impacted Files Coverage Δ
src/auditwheel/policy/__init__.py 98.24% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mayeut mayeut marked this pull request as ready for review April 23, 2023 10:56
@mayeut mayeut requested a review from lkollar April 23, 2023 10:57
@mayeut
Copy link
Member Author

mayeut commented Apr 23, 2023

@lkollar, I'm willing to take a chance on this one in order to get things started for armv7l builds on aarch64 systems with 32-bit userland. There are still things that require some checks but I think it will be easier to get feedback if we do release this (it could come with a big disclaimer that this is an alpha feature).

@mayeut mayeut merged commit aed555b into pypa:main Apr 24, 2023
@mayeut mayeut deleted the armv8l branch May 1, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants