Maint: Show test duration and limit to 15 failures. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
force-pushed
the
pyspeed
branch
3 times, most recently
from
9f6af2c
to
aeac1c2
Compare
hoodmane
reviewed
Sep 19, 2024
micropip/logging.py
Outdated
Comment on lines
92
to
97
| # need a default value because of __getattr__/__setattr__ | ||
| logger: logging.Logger = None # type: ignore[assignment] | ||
|
|
||
| def __init__(self, logger: logging.Logger): | ||
| self.logger = logger | ||
| # Bypassing __setattr__ by setting attributes directly in __dict__ | ||
| self.__dict__["logger"] = logger |
There was a problem hiding this comment.
What's the point of this? I don't understand.
There was a problem hiding this comment.
self.logger = ... call setattr, which itself, need self.logger, (in getattr(self.logger, ...,...), though self.logger is not defined so goes through getattr (infinite recursion). OTOH self.__dict__ exists, so all fine.
Basically #138 should be merged first, it fixes the failure on main, and then I'll rebased my own PRs on top of #138.
hoodmane
reviewed
Sep 19, 2024
Comment on lines
+55
to
+57
| --durations=10 \ | ||
| --dist-dir=./dist/ \ | ||
| --maxfail=15 \ |
I don't think it is worth contiuing testing if there is more than 15 failures. Also show the 10 slowest test, I'm hopping that will give us insight into how to make testing faster.
|
Rebased to remove the commits of #138 now that it is merged. |
agriyakhetarpal
approved these changes
Sep 19, 2024
|
Thanks, @Carreau! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think it is worth contiuing testing if there is more than 15 failures.
Also show the 10 slowest test, I'm hopping that will give us insight into how to make testing faster.