Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch HTTP implementation to reqwest #124

Merged
merged 4 commits into from
Oct 22, 2019

Commits on Oct 7, 2019

  1. Switch HTTP implementation to reqwest

    The prior HTTP implementation was `hyper`, and provided a low level
    of abstraction. This low level required me to implement redirect and
    proxy support. I omitted proxy support.
    
    Now, we use `reqwest` to handle HTTP. This allows us to delete our
    custom (but not special) redirect support and pick up proxy support.
    theotherjimmy committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    df9dd07 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2019

  1. Configuration menu
    Copy the full SHA
    596c117 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. Fix trait objects without explicit dyn.

    We have come rust compiler warnings:
    
    ```
    warning: trait objects without an explicit `dyn` are deprecated
       --> pdsc/src/component.rs:225:17
        |
    225 | ) -> Result<Box<Iterator<Item = ComponentBuilder>>, Error> {
        |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Iterator<Item = ComponentBuilder>`
        |
        = note: `#[warn(bare_trait_objects)]` on by default
    
       Compiling reqwest v0.9.22
       Compiling cmsis-update v0.1.0 (/home/jankii01/mbed/cmsis-pack-manager/rust/cmsis-update)
    warning: trait objects without an explicit `dyn` are deprecated
       --> cmsis-update/src/download.rs:153:14
        |
    153 |     ) -> Box<Future<Item = (), Error = Error> + 'a> {
        |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Future<Item = (), Error = Error> + 'a`
        |
        = note: `#[warn(bare_trait_objects)]` on by default
    
    warning: trait objects without an explicit `dyn` are deprecated
       --> cmsis-update/src/download.rs:188:14
        |
    188 |     ) -> Box<Stream<Item = PathBuf, Error = Error> + 'a>
        |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Stream<Item = PathBuf, Error = Error> + 'a`
    ```
    
    The compiler is pretty cool, as the warning it gives already tells you
    the real fix, too.
    Janne Kiiskila committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    6d74a42 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2 from JanneKiiskila/fix-dyn

    Fix trait objects without explicit `dyn`.
    theotherjimmy authored Oct 18, 2019
    Configuration menu
    Copy the full SHA
    156029f View commit details
    Browse the repository at this point in the history