scaling should be done before hdi computation posterior predictive #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 35 35
Lines 3525 3525
=======================================
Hits 3372 3372
Misses 153 153 ☔ View full report in Codecov by Sentry. |
radiokosmos
pushed a commit
to radiokosmos/pymc-marketing
that referenced
this pull request
Sep 3, 2024
twiecki
pushed a commit
that referenced
this pull request
Sep 10, 2024
twiecki
pushed a commit
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scaling step should be done before the hdi computation in the posterior predictive plot. Tested locally in mmm notebook ✅
📚 Documentation preview 📚: https://pymc-marketing--970.org.readthedocs.build/en/970/