Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UML permissions from forks / Run only on merge to main #967

Merged
merged 12 commits into from
Aug 24, 2024

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Aug 22, 2024

Description

Related Issue

  • Closes #
  • Related to #

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--967.org.readthedocs.build/en/967/

@wd60622
Copy link
Contributor Author

wd60622 commented Aug 22, 2024

Couldn't figure out the permissions as it would require the fork's owner to have the action bot permissions. Because of that, I just have it that if only runs when pymc-labs is the owner.

In a fork's case, it should only run when it is merged in. Which still keeps it up to date.

How does that sounds @juanitorduz ?

An alternative is to only run on merge to main. Do you have a preference?

@wd60622
Copy link
Contributor Author

wd60622 commented Aug 23, 2024

Personally, running only on main merge might be fine so that developer doesn't have to git pull origin <branch-name> a bunch

@juanitorduz
Copy link
Collaborator

Personally, running only on main merge might be fine so that developer doesn't have to git pull origin <branch-name> a bunch

The change on this PR looks good! Still, running only on main merge seems more convenient as you suggest, Feel free to push the change.

@wd60622 wd60622 changed the title Fix UML permissions from forks Fix UML permissions from forks / Run only on merge to main Aug 24, 2024
@wd60622 wd60622 merged commit 7d3b832 into pymc-labs:main Aug 24, 2024
10 of 11 checks passed
@wd60622 wd60622 deleted the fix-uml-permissions branch August 24, 2024 10:56
radiokosmos pushed a commit to radiokosmos/pymc-marketing that referenced this pull request Sep 3, 2024
…#967)

* change repo and python file change to kick off

* comment to check for failure

* using the repo

* delete to trigger

* the previous trigger

* push up again

* check for the owner being pymc-labs

* remove unused

* only run after merge to main
twiecki pushed a commit that referenced this pull request Sep 10, 2024
* change repo and python file change to kick off

* comment to check for failure

* using the repo

* delete to trigger

* the previous trigger

* push up again

* check for the owner being pymc-labs

* remove unused

* only run after merge to main
twiecki pushed a commit that referenced this pull request Sep 10, 2024
* change repo and python file change to kick off

* comment to check for failure

* using the repo

* delete to trigger

* the previous trigger

* push up again

* check for the owner being pymc-labs

* remove unused

* only run after merge to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants