Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log number of posterior & tuning samples #943

Merged
merged 5 commits into from
Aug 18, 2024
Merged

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Aug 18, 2024

Description

Add posterior_samples and tuning_samples to the logging

Here is the relevant subset in the MLflow UI:

updated-mlflow-logging

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--943.org.readthedocs.build/en/943/

@wd60622 wd60622 changed the title Additional mlflow params Log number of posterior & tuning samples Aug 18, 2024
@wd60622 wd60622 added the mlflow label Aug 18, 2024
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.68%. Comparing base (809a079) to head (38ad68d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #943   +/-   ##
=======================================
  Coverage   95.67%   95.68%           
=======================================
  Files          35       35           
  Lines        3516     3524    +8     
=======================================
+ Hits         3364     3372    +8     
  Misses        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wd60622
Copy link
Contributor Author

wd60622 commented Aug 18, 2024

Docs show up!
https://pymc-marketing--943.org.readthedocs.build/en/943/api/generated/pymc_marketing.mlflow.html

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wd60622

@juanitorduz juanitorduz merged commit 8d116b5 into main Aug 18, 2024
13 checks passed
@juanitorduz juanitorduz deleted the additional-mlflow-params branch August 18, 2024 17:42
radiokosmos pushed a commit to radiokosmos/pymc-marketing that referenced this pull request Sep 3, 2024
* helper command to view the artifacts from test

* pass tune from kwargs

* test for support of all samplers

* add mlflow as a mock import

* actual import as autolog is missing from docs
twiecki pushed a commit that referenced this pull request Sep 10, 2024
* helper command to view the artifacts from test

* pass tune from kwargs

* test for support of all samplers

* add mlflow as a mock import

* actual import as autolog is missing from docs
twiecki pushed a commit that referenced this pull request Sep 10, 2024
* helper command to view the artifacts from test

* pass tune from kwargs

* test for support of all samplers

* add mlflow as a mock import

* actual import as autolog is missing from docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mlflow module not showing up on the documentation page
2 participants