-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pymc-marketing version to some MMM notebooks #907
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
The issue with this is that it actually isn't 0.8.0 but what will come out in the next release. I.e. it is actually always ahead of the current release, right? What are your thoughts? |
I think for now we can add at least the lastest version. Another thing we can do is to update the version to 0.9.0dev while development |
Yeah, I am fine with that
Have something like that for this #860 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff
Let me remove the mmm example nb from this PR as I added it in #904 |
No 🙈 hehe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 33 33
Lines 3378 3378
=======================================
Hits 3195 3195
Misses 183 183 ☔ View full report in Codecov by Sentry. |
* nb part 1 * add mmm example nb * rm example nb
* nb part 1 * add mmm example nb * rm example nb
* nb part 1 * add mmm example nb * rm example nb
Related to #845
📚 Documentation preview 📚: https://pymc-marketing--907.org.readthedocs.build/en/907/