Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pymc-marketing version to some MMM notebooks #907

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Aug 2, 2024

Related to #845


📚 Documentation preview 📚: https://pymc-marketing--907.org.readthedocs.build/en/907/

@juanitorduz juanitorduz self-assigned this Aug 2, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz juanitorduz added the docs Improvements or additions to documentation label Aug 2, 2024
@wd60622
Copy link
Contributor

wd60622 commented Aug 2, 2024

The issue with this is that it actually isn't 0.8.0 but what will come out in the next release. I.e. it is actually always ahead of the current release, right? What are your thoughts?

@juanitorduz
Copy link
Collaborator Author

The issue with this is that it actually isn't 0.8.0 but what will come out in the next release. I.e. it is actually always ahead of the current release, right? What are your thoughts?

I think for now we can add at least the lastest version.

Another thing we can do is to update the version to 0.9.0dev while development

@wd60622
Copy link
Contributor

wd60622 commented Aug 2, 2024

I think for now we can add at least the lastest version.

Yeah, I am fine with that

Another thing we can do is to update the version to 0.9.0dev while development

Have something like that for this #860
Have you done this before?

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@juanitorduz
Copy link
Collaborator Author

Let me remove the mmm example nb from this PR as I added it in #904

@juanitorduz
Copy link
Collaborator Author

Have you done this before?

No 🙈 hehe

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.58%. Comparing base (dffae87) to head (2bf326d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #907   +/-   ##
=======================================
  Coverage   94.58%   94.58%           
=======================================
  Files          33       33           
  Lines        3378     3378           
=======================================
  Hits         3195     3195           
  Misses        183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz juanitorduz changed the title Add pymc-marketing version to notebooks Add pymc-marketing version to notebooks Aug 2, 2024
@juanitorduz juanitorduz changed the title Add pymc-marketing version to notebooks Add pymc-marketing version to some MMM notebooks Aug 2, 2024
@juanitorduz juanitorduz merged commit 41dd8a3 into main Aug 2, 2024
12 checks passed
@juanitorduz juanitorduz deleted the add_pymc_marketing_watermark branch August 2, 2024 13:15
radiokosmos pushed a commit to radiokosmos/pymc-marketing that referenced this pull request Sep 3, 2024
* nb part 1

* add mmm example nb

* rm example nb
twiecki pushed a commit that referenced this pull request Sep 10, 2024
* nb part 1

* add mmm example nb

* rm example nb
twiecki pushed a commit that referenced this pull request Sep 10, 2024
* nb part 1

* add mmm example nb

* rm example nb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants