Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add intercept and target variable to MMM component example #850

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Jul 21, 2024

Description

Add intercept and target with noise in order to put into context with a larger regression problem

Related Issue

  • Closes #
  • Related to #

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--850.org.readthedocs.build/en/850/

@wd60622 wd60622 added docs Improvements or additions to documentation MMM labels Jul 21, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wd60622 wd60622 requested a review from juanitorduz July 21, 2024 12:50
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.40%. Comparing base (7a8b627) to head (2c3b2f1).
Report is 201 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #850   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files          33       33           
  Lines        3288     3288           
=======================================
  Hits         3104     3104           
  Misses        184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

@juanitorduz juanitorduz self-requested a review July 22, 2024 10:53
@juanitorduz juanitorduz merged commit a98815f into main Jul 22, 2024
12 checks passed
@juanitorduz juanitorduz deleted the add-to-component-example branch July 22, 2024 11:08
twiecki pushed a commit that referenced this pull request Sep 10, 2024
twiecki pushed a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation MMM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants