-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create inverse_scaled_logistic_saturation and the corresponding class #827
Create inverse_scaled_logistic_saturation and the corresponding class #827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing stuff. Thanks for this contribution!
Can you test that the tranformation at lam is about 0.5? It should be test in transformations.py
pymc_marketing/mmm/transformers.py
Outdated
eps : float or array-like, optional, by default ln(3) | ||
Scaling parameter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add that this results in halfway saturation at lam
d04fb80
to
0baf5f4
Compare
…s and update default values
@wd60622 I've updated the PR with those changes, let me know if there's anything else I can do :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just running tests one last time
Thanks @arthurmello ! |
Description
Offer a more intuitive alternative to
$$f(x,λ)=\frac{1−e^{−xln(3)/λ}}{1+e^{−xln(3)/λ}}$$
logistic_saturation
, where we useInstead of the original:
$$f(x,λ)=\frac{1−e^{−xλ}}{1+e^{−xλ}}$$
Allowing for lambda to be interpreted as the half saturation point.
Related Issue
logistic_saturation
#220Checklist
Modules affected
Type of change
📚 Documentation preview 📚: https://pymc-marketing--827.org.readthedocs.build/en/827/