Remove warnings during tests #823
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #823 +/- ##
==========================================
+ Coverage 94.35% 94.38% +0.02%
==========================================
Files 32 33 +1
Lines 3261 3278 +17
==========================================
+ Hits 3077 3094 +17
Misses 184 184 ☔ View full report in Codecov by Sentry. |
|
WIP. The more the merrier |
|
Great 🙌 |
|
Only 7 warnings on the 3.10 tests now. Mainly from the CLV fits with potentials |
|
Bunch of warnings from pytest deprecations upcoming in python 3.14... |
| adstock_max_lag: int | None = Field( | ||
| None, | ||
| gt=0, | ||
| description="Number of lags to consider in the adstock transformation.", | ||
| ), |
There was a problem hiding this comment.
If we have a default of None we must ensure in the docstrings and the Field description what is the max lag used. From what I see below is 10 but this has to be explicit for the user in the docs :)
|
Thanks @wd60622 ! |
* address save and load tests * catch warning on load * remove warnings in budget optimizer * remove plotting warnings * remove validating warnings * consolidate the loading function * remove warnings in tests * incorporate the docstring feedback * only one deprecation warnings on DelayedSaturatedMMM * dont have deprecation on test
* address save and load tests * catch warning on load * remove warnings in budget optimizer * remove plotting warnings * remove validating warnings * consolidate the loading function * remove warnings in tests * incorporate the docstring feedback * only one deprecation warnings on DelayedSaturatedMMM * dont have deprecation on test
Description
Related Issue
Checklist
Modules affected
Type of change
📚 Documentation preview 📚: https://pymc-marketing--823.org.readthedocs.build/en/823/