-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save & load support for time varying parameters #815
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #815 +/- ##
==========================================
+ Coverage 94.38% 94.42% +0.03%
==========================================
Files 31 31
Lines 3207 3211 +4
==========================================
+ Hits 3027 3032 +5
+ Misses 180 179 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good but there is a test failing we need to fix before merging :)
Just fixed. New line in the string failed the regex |
* add missing init for save and load * get rid of warnings from JSON parsing * new error message without line break
* add missing init for save and load * get rid of warnings from JSON parsing * new error message without line break
Description
Related Issue
MMM.load
issue matching ids with tvp #814Checklist
Modules affected
Type of change
📚 Documentation preview 📚: https://pymc-marketing--815.org.readthedocs.build/en/815/