Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save & load support for time varying parameters #815

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Jul 8, 2024

Description

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--815.org.readthedocs.build/en/815/

@wd60622 wd60622 added bug Something isn't working MMM labels Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.42%. Comparing base (9b691a9) to head (829b142).
Report is 190 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
+ Coverage   94.38%   94.42%   +0.03%     
==========================================
  Files          31       31              
  Lines        3207     3211       +4     
==========================================
+ Hits         3027     3032       +5     
+ Misses        180      179       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wd60622 wd60622 requested a review from juanitorduz July 8, 2024 08:54
Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but there is a test failing we need to fix before merging :)

@wd60622
Copy link
Contributor Author

wd60622 commented Jul 8, 2024

It looks good but there is a test failing we need to fix before merging :)

Just fixed. New line in the string failed the regex

@wd60622 wd60622 requested a review from juanitorduz July 8, 2024 09:50
@juanitorduz juanitorduz merged commit 03e9215 into main Jul 8, 2024
12 checks passed
@juanitorduz juanitorduz deleted the save-load-bug branch July 8, 2024 10:13
twiecki pushed a commit that referenced this pull request Sep 10, 2024
* add missing init for save and load

* get rid of warnings from JSON parsing

* new error message without line break
twiecki pushed a commit that referenced this pull request Sep 10, 2024
* add missing init for save and load

* get rid of warnings from JSON parsing

* new error message without line break
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MMM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MMM.load issue matching ids with tvp
2 participants