Run example notebooks CI #791
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #791 +/- ##
=======================================
Coverage 93.86% 93.86%
=======================================
Files 28 28
Lines 2950 2950
=======================================
Hits 2769 2769
Misses 181 181 ☔ View full report in Codecov by Sentry. |
juanitorduz
force-pushed
the
ci_nb_script
branch
from
4a81294
to
2542c2e
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
juanitorduz
force-pushed
the
ci_nb_script
branch
from
bbf3e2a
to
7a66e89
Compare
|
@wd60622 @carlosagostini We have had many API changes, and the notebooks are hard to keep up 🙈 (see, for example, #793, which I discovered when working on this). I suggest this solution that is flexible and easy to manage. It runs locally very fast and in the CI takes 10 min, which is comparable to the tests we have in place. WDYT? |
Good idea! Added in fe3cdf7 |
Can you run that twice in a row? i.e. does the runner still work if the files already exist? |
|
@wd60622 im sorry but I don't understand the question 🙈😄 |
does make run_notebooks
make run_notebookswork? |
Woks locally ✅ |
* run notebooks init * change kernel name * change kernel name * change kernel name * rm docs * add nb * fix nb * fig dpi * update model object * no output * test mmm notebooks * fix path * graphviz * sudo * paralelize and Path * reqs * undo * comments * try budget allocation * add quickstart * ignore budget allocation * add make command * use make
* run notebooks init * change kernel name * change kernel name * change kernel name * rm docs * add nb * fix nb * fig dpi * update model object * no output * test mmm notebooks * fix path * graphviz * sudo * paralelize and Path * reqs * undo * comments * try budget allocation * add quickstart * ignore budget allocation * add make command * use make
I am revisiring #624 . We can do it via
readthedocsbut I want to get feedback on this simpler solution.📚 Documentation preview 📚: https://pymc-marketing--791.org.readthedocs.build/en/791/