-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run example notebooks CI #791
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #791 +/- ##
=======================================
Coverage 93.86% 93.86%
=======================================
Files 28 28
Lines 2950 2950
=======================================
Hits 2769 2769
Misses 181 181 ☔ View full report in Codecov by Sentry. |
4a81294
to
2542c2e
Compare
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
bbf3e2a
to
7a66e89
Compare
@wd60622 @carlosagostini We have had many API changes, and the notebooks are hard to keep up 🙈 (see, for example, #793, which I discovered when working on this). I suggest this solution that is flexible and easy to manage. It runs locally very fast and in the CI takes 10 min, which is comparable to the tests we have in place. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and will be a lifesafer.
How about a command in the Makefile as well? make notebooks
or something like that to do the runner
Good idea! Added in fe3cdf7 |
Can you run that twice in a row? i.e. does the runner still work if the files already exist? |
@wd60622 im sorry but I don't understand the question 🙈😄 |
does make run_notebooks
make run_notebooks work? |
Woks locally ✅ |
* run notebooks init * change kernel name * change kernel name * change kernel name * rm docs * add nb * fix nb * fig dpi * update model object * no output * test mmm notebooks * fix path * graphviz * sudo * paralelize and Path * reqs * undo * comments * try budget allocation * add quickstart * ignore budget allocation * add make command * use make
* run notebooks init * change kernel name * change kernel name * change kernel name * rm docs * add nb * fix nb * fig dpi * update model object * no output * test mmm notebooks * fix path * graphviz * sudo * paralelize and Path * reqs * undo * comments * try budget allocation * add quickstart * ignore budget allocation * add make command * use make
I am revisiring #624 . We can do it via
readthedocs
but I want to get feedback on this simpler solution.📚 Documentation preview 📚: https://pymc-marketing--791.org.readthedocs.build/en/791/