Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prior predictive example notebook #787

Merged
merged 6 commits into from
Jun 28, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Jun 27, 2024


📚 Documentation preview 📚: https://pymc-marketing--787.org.readthedocs.build/en/787/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz juanitorduz added docs Improvements or additions to documentation MMM priority: high labels Jun 27, 2024
@juanitorduz juanitorduz added this to the 0.7.0 milestone Jun 27, 2024
@juanitorduz
Copy link
Collaborator Author

When adding the prior-predictive step, the processing is wrong:

image

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.86%. Comparing base (f6a1a37) to head (16d3656).
Report is 183 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
- Coverage   93.90%   93.86%   -0.04%     
==========================================
  Files          28       28              
  Lines        2951     2950       -1     
==========================================
- Hits         2771     2769       -2     
- Misses        180      181       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz juanitorduz added the bug Something isn't working label Jun 27, 2024
@wd60622
Copy link
Contributor

wd60622 commented Jun 27, 2024

Would the self.y be getting scaled twice?
If you remove the sample_prior_predictive lines, this doesn't happen, right?

@juanitorduz
Copy link
Collaborator Author

juanitorduz commented Jun 27, 2024

The bug was fixed in b765b38 . This one was hard to catch, see #788

@juanitorduz juanitorduz requested a review from wd60622 June 27, 2024 14:22
@wd60622
Copy link
Contributor

wd60622 commented Jun 28, 2024

Is it then the combination of build_model and _data_setter? As the sample_posterior_predictive method will call _data_setter but not the build_model...

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notebook looks good! Just question but not a blocker

@juanitorduz
Copy link
Collaborator Author

Is it then the combination of build_model and _data_setter? As the sample_posterior_predictive method will call _data_setter but not the build_model...

I think we need to take a detailed look at how this is happening and that is why I created the issue above 😬. Let me merge this one and then work on the other issue.

@juanitorduz juanitorduz merged commit fafe354 into main Jun 28, 2024
11 checks passed
twiecki pushed a commit that referenced this pull request Sep 10, 2024
twiecki pushed a commit that referenced this pull request Sep 10, 2024
@twiecki twiecki deleted the prior_predictive_mmm_example_nb branch September 11, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Improvements or additions to documentation MMM model builder priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants