-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model.fit
doesn't remove prior samples
#741
Conversation
@@ -86,7 +86,7 @@ def __init__( | |||
self.model_config = ( | |||
self.default_model_config | model_config | |||
) # parameters for priors etc. | |||
self.model: pm.Model | None = None # Set by build_model | |||
self.model: pm.Model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we don't have to check self.model is None
all the time...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
==========================================
+ Coverage 93.74% 93.81% +0.07%
==========================================
Files 27 27
Lines 2828 2828
==========================================
+ Hits 2651 2653 +2
+ Misses 177 175 -2 ☔ View full report in Codecov by Sentry. |
model.fit
doesn't remove prior samples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
* type hint only * more informative errors * check for attr * remove type ignore * check for attr * check for attr * reduce indentation * new error names
* type hint only * more informative errors * check for attr * remove type ignore * check for attr * check for attr * reduce indentation * new error names
Description
The following workflow is now supported
Doesn't touch on the "fit_data_group" introduced with #414
Related Issue
Checklist
Modules affected
Type of change
📚 Documentation preview 📚: https://pymc-marketing--741.org.readthedocs.build/en/741/