Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass kwargs to minimizer #737

Merged
merged 6 commits into from
Jun 12, 2024
Merged

pass kwargs to minimizer #737

merged 6 commits into from
Jun 12, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Jun 11, 2024

Closes #729


📚 Documentation preview 📚: https://pymc-marketing--737.org.readthedocs.build/en/737/

@juanitorduz juanitorduz changed the title passd kwargs passd kwargs to minimizer Jun 11, 2024
@juanitorduz juanitorduz changed the title passd kwargs to minimizer pass kwargs to minimizer Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.60%. Comparing base (46ba03f) to head (b6dae69).
Report is 117 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
+ Coverage   93.59%   93.60%   +0.01%     
==========================================
  Files          27       27              
  Lines        2716     2721       +5     
==========================================
+ Hits         2542     2547       +5     
  Misses        174      174              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz juanitorduz self-assigned this Jun 11, 2024
Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the end of the world since the code looks fine

tests/mmm/test_budget_optimizer.py Show resolved Hide resolved
@juanitorduz juanitorduz requested a review from wd60622 June 11, 2024 21:15
Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@juanitorduz juanitorduz merged commit b6a938f into main Jun 12, 2024
10 checks passed
twiecki pushed a commit that referenced this pull request Sep 10, 2024
twiecki pushed a commit that referenced this pull request Sep 10, 2024
@twiecki twiecki deleted the kwargs_budget_optimization2 branch September 11, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose minimization kwargs in budget optimization
2 participants