Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use URL for README image #715

Merged
merged 3 commits into from
Jun 3, 2024
Merged

use URL for README image #715

merged 3 commits into from
Jun 3, 2024

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Jun 3, 2024

Description

Use URLs instead of relative paths in README should make the PyPI page a bit nicer 🎉

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--715.org.readthedocs.build/en/715/

@wd60622 wd60622 added docs Improvements or additions to documentation no releasenotes labels Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (7be19f6) to head (2961f5b).
Report is 112 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #715   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files          24       24           
  Lines        2520     2520           
=======================================
  Hits         2333     2333           
  Misses        187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twiecki twiecki merged commit ba41aef into main Jun 3, 2024
10 checks passed
@twiecki twiecki deleted the url-for-image branch June 3, 2024 14:52
@wd60622 wd60622 mentioned this pull request Jun 11, 2024
twiecki pushed a commit that referenced this pull request Sep 10, 2024
* use URL for image

* additional links that are relative

* remove forward slashes in URL
twiecki pushed a commit that referenced this pull request Sep 10, 2024
* use URL for image

* additional links that are relative

* remove forward slashes in URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation no releasenotes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative path doesn't show image on PyPI
2 participants