Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock version by footer #714

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Unblock version by footer #714

merged 1 commit into from
Jun 3, 2024

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Jun 3, 2024

Description

Unblock the hidden version toggle caused by the footer of the page.

The footer should only show up when scrolled to the bottom of the page now

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--714.org.readthedocs.build/en/714/

@wd60622 wd60622 added docs Improvements or additions to documentation no releasenotes labels Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (7be19f6) to head (1eb4cae).
Report is 112 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #714   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files          24       24           
  Lines        2520     2520           
=======================================
  Hits         2333     2333           
  Misses        187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wd60622
Copy link
Contributor Author

wd60622 commented Jun 3, 2024

This looks good to me in the build on desktop as well as mobile!

@twiecki twiecki merged commit 86805a4 into main Jun 3, 2024
11 checks passed
twiecki pushed a commit that referenced this pull request Sep 10, 2024
twiecki pushed a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation no releasenotes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs version switch button hidden until one scrolls to the end of page
2 participants