Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add spaces, increase indentation, and fix number order to Pareto notebook #651

Merged
merged 2 commits into from
Apr 27, 2024
Merged

add spaces, increase indentation, and fix number order to Pareto notebook #651

merged 2 commits into from
Apr 27, 2024

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Apr 27, 2024 •
edited
Loading

Description

Fixing three things I noticed while opening up the docs here and here

  • There needs to be only one Header 1 or they show up outside along with the other notebooks
  • The latex was rendering differently in the notebook than in the sphinx docs. Hence my issue Speed up sphinx builds #650
  • The numbers jump from 3 to 5 instead to 4

Related Issue

  • Closes #
  • Related to #

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--651.org.readthedocs.build/en/651/

@wd60622 wd60622 added docs Improvements or additions to documentation CLV no releasenotes labels Apr 27, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@wd60622
Copy link
Contributor Author

wd60622 commented Apr 27, 2024 •
edited
Loading

Before:

Screenshot 2024-04-27 at 12 48 37 Screenshot 2024-04-27 at 12 48 24

After:

Screenshot 2024-04-27 at 12 52 26 Screenshot 2024-04-27 at 12 52 33

juanitorduz
juanitorduz approved these changes Apr 27, 2024
View reviewed changes
Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@juanitorduz juanitorduz merged commit 7034e28 into pymc-labs:main Apr 27, 2024
9 checks passed
@juanitorduz juanitorduz mentioned this pull request May 2, 2024
Merged
twiecki pushed a commit that referenced this pull request Sep 10, 2024
@wd60622 @twiecki
add spaces, increase indentation, and fix number order to Pareto note…
fd09fa7 
…book (#651)

* add spaces, increase indentation, and fix number order

* explicit with 6
twiecki pushed a commit that referenced this pull request Sep 10, 2024
@wd60622 @twiecki
add spaces, increase indentation, and fix number order to Pareto note…
43fe29a 
…book (#651)

* add spaces, increase indentation, and fix number order

* explicit with 6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanitorduz juanitorduz juanitorduz approved these changes

@ColtAllen ColtAllen Awaiting requested review from ColtAllen

Assignees
No one assigned
Labels
CLV docs Improvements or additions to documentation no releasenotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wd60622 @juanitorduz