Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UP rule ruff #635

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Add UP rule ruff #635

merged 3 commits into from
Apr 16, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Apr 16, 2024

Add UP rule ruff (we also use it in PyMC). We also dropped support for Python 3.9 (#615) so the type hints should not cause harm.


📚 Documentation preview 📚: https://pymc-marketing--635.org.readthedocs.build/en/635/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.62%. Comparing base (4a737cf) to head (60e7f46).

Files Patch % Lines
pymc_marketing/mmm/base.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
+ Coverage   91.61%   91.62%   +0.01%     
==========================================
  Files          22       22              
  Lines        2277     2280       +3     
==========================================
+ Hits         2086     2089       +3     
  Misses        191      191              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz juanitorduz self-assigned this Apr 16, 2024
@juanitorduz juanitorduz merged commit 2be2f63 into main Apr 16, 2024
10 checks passed
@juanitorduz juanitorduz deleted the add_UP_rule branch April 16, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants