Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pareto Intro Notebook #627

Closed
wants to merge 2 commits into from
Closed

Pareto Intro Notebook #627

wants to merge 2 commits into from

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Apr 15, 2024

Add a notebook for the Pareto model similar to https://www.pymc-marketing.io/en/stable/notebooks/clv/bg_nbd.html


📚 Documentation preview 📚: https://pymc-marketing--627.org.readthedocs.build/en/627/

@juanitorduz juanitorduz self-assigned this Apr 15, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz juanitorduz marked this pull request as draft April 15, 2024 10:18
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.95%. Comparing base (e2dba27) to head (d6230a0).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #627       +/-   ##
===========================================
- Coverage   91.61%   34.95%   -56.66%     
===========================================
  Files          22       22               
  Lines        2277     2277               
===========================================
- Hits         2086      796     -1290     
- Misses        191     1481     +1290     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz juanitorduz added docs Improvements or additions to documentation enhancement New feature or request CLV labels Apr 15, 2024
@@ -0,0 +1,4408 @@
{
Copy link
Contributor

@wd60622 wd60622 Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*lifetime8 -> lifetime under dropout process 3.?


Reply via ReviewNB

@ColtAllen
Copy link
Collaborator

We've been doing duplicate work 😬
https://github.com/ColtAllen/pymc-marketing/blob/pnbd_notebook/docs/source/notebooks/clv/pareto_nbd.ipynb

Everything above the ParetoNBD Model in pymc_marketing header is what I've got so far; the remainder is a bunch of scratchpad code that'll likely get wiped.

@juanitorduz
Copy link
Collaborator Author

@ColtAllen I was not sure about this and that is why I pushed this nb. I simply replaced bg -> pareto
So I can close this one 😅

@ColtAllen
Copy link
Collaborator

I'll open a PR for mine this week; sorry for the lack of communication on my part.

@twiecki twiecki deleted the pareto_nb branch September 11, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLV docs Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants